Rust: Update legacy MaD models 4 #19948
Conversation
…r these last few cases).
geoffw0
added
no-change-note-required
|
I think it will be prudent to get the first two/three PRs merged before attempting to address the test failures here. |
|
The test failures look The relevant bits of code are
I would expect the canonical path to be either This should address the underlying issue #19988 |
|
I've brought in the fix for |
aibaars
left a comment
aibaars
left a comment
There was a problem hiding this comment.
I think all the MISSING annotations can be fixed by updating the models to match the actual canonical paths. The following queries can come in handy to investigate what the computed canonical paths are:
query predicate resolvedPaths2(CallExprBase e, string path, Addressable target) {
toBeTested(e) and
target = e.getStaticTarget() and
path = concat(target.getCanonicalPath())
}
query predicate resolvedPaths3( Addressable target, string path) { path = target.getCanonicalPath() }
Yes I've been doing something similar. The issue being that quite a lot of canonical paths were missing (the situation is improving quite fast) so I had to fill in the gaps myself, and I appear to have made a few typos in that process. |
|
DCA LGTM. This is ready for approval I think. |
2 participants
Final update of legacy MaD models to the new model format (continues from #19946 and should be independent of that).
There's a lot of guesswork involved in this last set of changes - i.e. cases where I couldn't find a real
getCanonicalPath. There should be tests for most of them though so we will find out if we're way off.